Re: [RFC PATCH 1/8] rust: kernel: add basic abstractions for device-mapper
From: Greg KH
Date: Sun Jun 25 2023 - 08:25:50 EST
On Sun, Jun 25, 2023 at 08:16:50PM +0800, Qingsong Chen wrote:
> - Declare `vtable` for basic target operations.
> - Wrap `target_type` to register/unregister target.
> - Wrap `dm_target`/`dm_dev` to handle io request.
> - Add a dummy `bio` wrapper.
Shouldn't this be all different commits, and different files? A bio
shouldn't be defined in the device_mapper.rs file, as that would prevent
anyone else from accessing it.
thanks,
greg k-h