Re: [PATCH 02/26] octeon_ep: use array_size

[Christophe JAILLET]

Le 25/06/2023 à 22:25, Julia Lawall a écrit :
> On Sun, 25 Jun 2023, Christophe JAILLET wrote:
>
> > Le 25/06/2023 à 00:28, Jakub Kicinski a écrit :
> > > On Fri, 23 Jun 2023 23:14:33 +0200 Julia Lawall wrote:
> > > > -	oq->buff_info = vzalloc(oq->max_count * OCTEP_OQ_RECVBUF_SIZE);
> > > > +	oq->buff_info = vzalloc(array_size(oq->max_count,
> > > > OCTEP_OQ_RECVBUF_SIZE));
> > >
> > > vcalloc seems to exist, is there a reason array_size() is preferred?
> >
> > Hi,
> >
> > just for your information, I've just sent [1].
> >
> > CJ
> >
> > [1]:
> > https://lore.kernel.org/all/3484e46180dd2cf05d993ff1a78b481bc2ad1f71.1687723931.git.christophe.jaillet@xxxxxxxxxx/
>
> For some reason, I have only received Christophe's mail, not Jakub's...
>
> In any case, thanks for pointing out the existence of these functions.  I
> just redid what Kees did in 2018, when I guess these functions didn't
> exist.  I will look more carefully to see what functions are now available
> and resend the whole thing.

Hi,

should you want to go 1 step further and simplify some code:

git grep v[mz]alloc.*array_size\( | wc -l
174

CJ

> Thanks!
>
> julia