Re: [PATCH v2 6/6] meson saradc: support reading from channel7 mux inputs

[Martin Blumenstingl]

Hi George,

On Fri, Jun 23, 2023 at 6:38 PM George Stark <gnstark@xxxxxxxxxxxxxx> wrote:
[...]
> So I think to return to double definition of meson_sar_adc_iio_channels and keep the driver backwards compatible.
Ack!

> I've just realized another moment with channels defined after MESON_SAR_ADC_TEMP_CHAN in channel array.
Good catch

> In dts by default channels are referenced by channel array index not even by channel number.
> So channel e.g MUX_0_VSS will have the same number (due to enum patch) but different index on meson8 and gxbb.
> As alternative we can implement fwnode_xlate method in meson adc driver and use channel numbers in dts (probably not in the current patchset)
That is actually an interesting third approach. But as you said: let's
start simple and add the tables back for now.


Best regards,
Martin