Re: [PATCH] perf tests: Fix test_arm_callgraph_fp variable expansion

From: James Clark
Date: Mon Jun 26 2023 - 04:09:34 EST




On 23/06/2023 17:56, Markus Elfring wrote:
>
>> At the same time silence the shellcheck warning for that line and fix
>> two more shellcheck errors at the end of the script.
>
> Does such a wording really fit to the known requirement “Solve only one problem per patch.”?
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4-rc7#n81
>
>
> Regards,
> Markus

I think so, it fixes all the shellcheck errors that were claimed to be
fixed and introduced by the referenced fix.

To be honest I would have rather just reverted the original change
completely because it was obviously never tested.