Re: Build regressions/improvements in v6.4

[Geert Uytterhoeven]

On Mon, 26 Jun 2023, Geert Uytterhoeven wrote:
> JFYI, when comparing v6.4[1] to v6.4-rc7[3], the summaries are:
>  - build errors: +1/-0

  + /kisskb/src/drivers/net/wireless/cisco/airo.c: error: 'status_rid.currentXmitRate' is used uninitialized [-Werror=uninitialized]:  => 6163:45

sh4-gcc11/sh-allmodconfig
seen before

This is actually a real issue, and it's been here since basically forever.

drivers/net/wireless/cisco/airo.c:

    static int airo_get_rate(struct net_device *dev,
                             struct iw_request_info *info,
                             union iwreq_data *wrqu,
                             char *extra)
    {
            struct iw_param *vwrq = &wrqu->bitrate;
            struct airo_info *local = dev->ml_priv;
            StatusRid status_rid;           /* Card status info */

            readStatusRid(local, &status_rid, 1);

==>         vwrq->value = le16_to_cpu(status_rid.currentXmitRate) * 500000;
            ...
    }

    static int readStatusRid(struct airo_info *ai, StatusRid *statr, int lock)
    {
            return PC4500_readrid(ai, RID_STATUS, statr, sizeof(*statr), lock);
    }

    static int PC4500_readrid(struct airo_info *ai, u16 rid, void *pBuf, int len, int lock)
    {
            u16 status;
            int rc = SUCCESS;

            if (lock) {
                    if (down_interruptible(&ai->sem))
                            return ERROR;

pBuf output buffer contents not initialized.

            }
            ...
    }


> [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/6995e2de6891c724bfeb2db33d7b87775f913ad1/ (all 160 configs)
> [3] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/45a3e24f65e90a047bef86f927ebdc4c710edaa1/ (all 160 configs)

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds