Re: [PATCH net-next] libceph: Partially revert changes to support MSG_SPLICE_PAGES

From: Ilya Dryomov
Date: Mon Jun 26 2023 - 15:49:14 EST


On Mon, Jun 26, 2023 at 9:18 PM David Howells <dhowells@xxxxxxxxxx> wrote:
>
> Ilya Dryomov <idryomov@xxxxxxxxx> wrote:
>
> > This patch appears to be mangled.
>
> Mangled? Did you see tab -> space conversion? I see that in your reply, but
> in the copy I got it's fine.

It turns out that it applies fine with "git am" but "git apply --check"
complains as follows:

error: patch fragment without header at line 203: @@ -450,10 +482,6 @@
static int write_partial_message_data(struct ceph_con=

I think it's due to the quoted-printable encoding. I didn't have any
issues with your previous patches using the same automation so I just
assumed the patch to be mangled in the usual way.

Sorry for the noise, now that I can see the cumulative diff, I will
review shortly.

Thanks,

Ilya