Re: [PATCH] counter: Fix menuconfig "Counter support" submenu entries disappearance

From: William Breathitt Gray
Date: Mon Jun 26 2023 - 18:20:14 EST


On Sun, Jun 25, 2023 at 12:11:08PM +0100, Jonathan Cameron wrote:
> On Tue, 20 Jun 2023 17:12:13 -0400
> William Breathitt Gray <william.gray@xxxxxxxxxx> wrote:
>
> > On Tue, Jun 20, 2023 at 02:00:37PM -0700, Randy Dunlap wrote:
> > > Hi,
> > >
> > > On 6/20/23 10:01, William Breathitt Gray wrote:
> > > > The current placement of the I8254 Kconfig entry results in the
> > > > disappearance of the "Counter support" submenu items in menuconfig. Move
> > > > the I8254 above the menuconfig COUNTER entry to restore the intended
> > > > submenu behavior.
> > > >
> > > > Fixes: d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module")
> > > > Reported-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
> > > > Closes: https://lore.kernel.org/all/32ddaa7b-53a8-d61f-d526-b545bd561337@xxxxxxxxxxxxxxx/
> > > > Signed-off-by: William Breathitt Gray <william.gray@xxxxxxxxxx>
> > >
> > > Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> > >
> > > but why is I8254 here at all? Users cannot enable it
> > > and nothing selects it. Is it a WIP?
> > >
> > > Thanks.
> >
> > There are pending patches for two drivers to use it: 104-dio-48e[^1] and
> > stx104[^2]. Those will be picked up in their respective subsystem trees
> > (by Bart and Jonathan I presume).
> >
>
> I missed the IIO patch in that series. Could you resend please.
>
> Jonathan
>
> > William Breathitt Gray
> >
> > [^1]: https://lore.kernel.org/all/dc4d0d5ca6ea28eda18815df114ecb21226cb345.1681665189.git.william.gray@xxxxxxxxxx/
> > [^2]: https://lore.kernel.org/all/45d35b6f6e8d51df788b2bc85c456bfd45476b1a.1681665189.git.william.gray@xxxxxxxxxx/

I8254 is expected to land in 6.5 so I'll wait and resend the IIO patch
rebased on 6.5-rc1 once it's released in a couple weeks. That'll make
things simple for you and avoid the need for an immutable branch.

William Breathitt Gray

Attachment: signature.asc
Description: PGP signature