Re: [PATCH 2/2] arm64: dts: add support for T7 based Amlogic AN400

[Xianwei Zhao]

Hi Krzysztof,
      Thank you for your review.

On 2023/6/26 23:41, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On 26/06/2023 11:52, Xianwei Zhao wrote:
> > Amlogic T7 is an advanced application processor designed for smart display.
> >
> > Add basic support for the T7 based Amlogic AN400 board, which describes
> > the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
> > booting up into the serial console.
> Few nits.
Is it possible to be more specific about it?
> ...
>
> > +                             core3 {
> > +                                     cpu = <&cpu7>;
> > +                             };
> > +                     };
> > +             };
> > +
> > +             cpu0:cpu@0 {
> You miss spaces after labels.
Will do.
> > +                     device_type = "cpu";
> > +                     compatible = "arm,cortex-a73";
> > +                     reg = <0x0 0x0>;
> > +                     enable-method = "psci";
> > +             };
> > +
> > +             cpu1:cpu@1 {
> > +                     device_type = "cpu";
> > +                     compatible = "arm,cortex-a73";
> > +                     reg = <0x0 0x1>;
> > +                     enable-method = "psci";
> > +             };
> > +
> > +             cpu2:cpu@2 {
> > +                     device_type = "cpu";
> > +                     compatible = "arm,cortex-a73";
> > +                     reg = <0x0 0x2>;
> > +                     enable-method = "psci";
> > +             };
> > +
> > +             cpu3:cpu@3 {
> > +                     device_type = "cpu";
> > +                     compatible = "arm,cortex-a73";
> > +                     reg = <0x0 0x3>;
> > +                     enable-method = "psci";
> > +             };
> > +
> > +             cpu4:cpu@100 {
> > +                     device_type = "cpu";
> > +                     compatible = "arm,cortex-a53";
> > +                     reg = <0x0 0x100>;
> > +                     enable-method = "psci";
> > +             };
> > +
> > +             cpu5:cpu@101{
> > +                     device_type = "cpu";
> > +                     compatible = "arm,cortex-a53";
> > +                     reg = <0x0 0x101>;
> > +                     enable-method = "psci";
> > +             };
> > +
> > +             cpu6:cpu@102 {
> > +                     device_type = "cpu";
> > +                     compatible = "arm,cortex-a53";
> > +                     reg = <0x0 0x102>;
> > +                     enable-method = "psci";
> > +             };
> > +
> > +             cpu7:cpu@103 {
> > +                     device_type = "cpu";
> > +                     compatible = "arm,cortex-a53";
> > +                     reg = <0x0 0x103>;
> > +                     enable-method = "psci";
> > +             };
> > +     };
> > +
> > +     timer {
> > +             compatible = "arm,armv8-timer";
> > +             interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
> > +                          <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
> > +                          <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
> > +                          <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>;
> > +     };
> > +
> > +     psci {
> > +             compatible = "arm,psci-0.2";
> > +             method = "smc";
> > +     };
> > +
> > +     xtal: xtal-clk {
> > +             compatible = "fixed-clock";
> > +             clock-frequency = <24000000>;
> > +             clock-output-names = "xtal";
> > +             #clock-cells = <0>;
> > +     };
> > +
> > +     soc {
> > +             compatible = "simple-bus";
> > +             #address-cells = <2>;
> > +             #size-cells = <2>;
> > +             ranges;
> > +
> > +             gic: interrupt-controller@fff01000 {
> > +                     compatible = "arm,gic-400";
> > +                     #interrupt-cells = <3>;
> > +                     #address-cells = <0>;
> > +                     interrupt-controller;
> > +                     reg = <0x0 0xfff01000 0 0x1000>,
> > +                         <0x0 0xfff02000 0 0x0100>;
> > +                     interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>;
> > +                  };
> Fix indentation.
Will do.
> > +
> > +             apb4: bus@fe000000 {
> > +                     compatible = "simple-bus";
> > +                     reg = <0x0 0xfe000000 0x0 0x480000>;
> > +                     #address-cells = <2>;
> > +                     #size-cells = <2>;
> > +                     ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
> > +
> > +                     uart_a: serial@78000 {
> > +                             compatible = "amlogic,meson-s4-uart",
> > +                                          "amlogic,meson-ao-uart";
> > +                             reg = <0x0 0x78000 0x0 0x18>;
> > +                             interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
> > +                             status = "disabled";
> Please, don't put status in the middle of properties...
Will put status in the end of properties in next version.
> Best regards,
> Krzysztof