Re: [PATCH v4 3/3] dt-bindings: ufs: qcom: Fix sm8450 bindings

[Krzysztof Kozlowski]

On 27/06/2023 10:29, Luca Weiss wrote:
> On Mon Jun 26, 2023 at 10:27 AM CEST, Krzysztof Kozlowski wrote:
>> On 26/06/2023 10:15, Luca Weiss wrote:
>>> SM8450 actually supports ICE (Inline Crypto Engine) so adjust the
>>> bindings and the example to match.
>>>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>>> Reviewed-by: Eric Biggers <ebiggers@xxxxxxxxxx>
>>> Reviewed-by: Iskren Chernev <me@xxxxxxxxxxx>
>>> Signed-off-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
>>
>> SM8450 should be rather converted to qcom,ice.
> 
> In v5 sm8450 is now using ICE, both in dtsi and binding example. But I
> guess you could also argue reg-names should be purged from dtsi and
> binding completely and to convert all existing dtsi to use the
> standalone ice node, right?

It would be good, but that's no exactly my goal. My goal is to have
dtbs_check without errors.

> 
> But I'd also like for this series to finally land at some point, we can
> do this later, okay?

I need to look at v5 then.


Best regards,
Krzysztof