Re: [PATCH v3 0/3] Fix some checkpatch issues
From: Franziska Näpelt
Date: Wed Jun 28 2023 - 12:38:21 EST
Hi Philipp,
Am Mo., 26. Juni 2023 um 19:09 Uhr schrieb Philipp Hortmann
<philipp.g.hortmann@xxxxxxxxx>:
>
> On 6/25/23 17:56, Franziska Naepelt wrote:
> > This is a series of patches to fix some trivial checkpatch issues. Not all
> > issues have been fixed. I intend to submit another series to fix more stuff.
> >
> > Testing:
> >
> > ---
> > v3: Series to contain only remaining patches.
> >
> > Franziska Naepelt (3):
> > staging: rtl8723bs: Fix space issues
> > staging: rtl8723bs: Fix alignment open parenthesis
> > staging: rtl8723bs: Fix remaining blank line issue
> >
> > .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 164 +++++++++---------
> > 1 file changed, 85 insertions(+), 79 deletions(-)
> >
> > --
> > 2.39.2 (Apple Git-143)
> >
> >
>
> checkpatch prints the following warning:
> WARNING: From:/Signed-off-by: email address mismatch: 'From: Franziska
> Naepelt <franziska.naepelt@xxxxxxxxxxxxxx>' != 'Signed-off-by: Franziska
> Naepelt <franziska.naepelt@xxxxxxxxx>'
>
> I propose you change the git email matching the one that you use to send.
>
> When testing you can compile the driver with this command:
> make -C . M=drivers/staging/rtl8723bs
> Typically a compile of the entire kernel is not required.
>
> Please use the subsystem and driver also for the Subject line of the
> cover letter.
>
> Bye Philipp
Do you want me to submit v4 to fix the email address as well as the subject of
the cover letter or are you ok with me promising to make it properly the next
time? ;)
Thanks,
Franziska