Re: [PATCH 6/7] xfs: Convert to bdev_logical_block_mask()

From: Bill O'Donnell
Date: Wed Jun 28 2023 - 12:42:32 EST


On Wed, Jun 28, 2023 at 05:34:59PM +0800, Yangtao Li wrote:
> Use bdev_logical_block_mask() to simplify code.
>
> Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>

Reviewed-by: Bill O'Donnell <bodonnel@xxxxxxxxxx>

> ---
> fs/xfs/xfs_buf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
> index 15d1e5a7c2d3..f784daa21219 100644
> --- a/fs/xfs/xfs_buf.c
> +++ b/fs/xfs/xfs_buf.c
> @@ -1968,7 +1968,7 @@ xfs_setsize_buftarg(
>
> /* Set up device logical sector size mask */
> btp->bt_logical_sectorsize = bdev_logical_block_size(btp->bt_bdev);
> - btp->bt_logical_sectormask = bdev_logical_block_size(btp->bt_bdev) - 1;
> + btp->bt_logical_sectormask = bdev_logical_block_mask(btp->bt_bdev);
>
> return 0;
> }
> --
> 2.39.0
>