Re: [PATCH v2] hwmon: (pmbus/acbel-fsg032) Add firmware version debugfs attribute
From: kernel test robot
Date: Wed Jun 28 2023 - 20:51:08 EST
Hi Eddie,
kernel test robot noticed the following build warnings:
[auto build test WARNING on groeck-staging/hwmon-next]
[also build test WARNING on linus/master v6.4 next-20230628]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Eddie-James/hwmon-pmbus-acbel-fsg032-Add-firmware-version-debugfs-attribute/20230628-233840
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
patch link: https://lore.kernel.org/r/20230628153453.122213-1-eajames%40linux.ibm.com
patch subject: [PATCH v2] hwmon: (pmbus/acbel-fsg032) Add firmware version debugfs attribute
config: i386-randconfig-i012-20230628 (https://download.01.org/0day-ci/archive/20230629/202306290818.2IuC4QCQ-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230629/202306290818.2IuC4QCQ-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306290818.2IuC4QCQ-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/hwmon/pmbus/acbel-fsg032.c: In function 'acbel_fsg032_debugfs_read':
>> drivers/hwmon/pmbus/acbel-fsg032.c:25:13: warning: unused variable 'i' [-Wunused-variable]
25 | int i;
| ^
vim +/i +25 drivers/hwmon/pmbus/acbel-fsg032.c
17
18 static ssize_t acbel_fsg032_debugfs_read(struct file *file, char __user *buf, size_t count,
19 loff_t *ppos)
20 {
21 struct i2c_client *client = file->private_data;
22 char data[I2C_SMBUS_BLOCK_MAX + 2] = { 0 };
23 char out[8];
24 int rc;
> 25 int i;
26
27 rc = i2c_smbus_read_block_data(client, ACBEL_MFR_FW_REVISION, data);
28 if (rc < 0)
29 return rc;
30
31 rc = snprintf(out, sizeof(out), "%*phN\n", min(rc, 3), data);
32 return simple_read_from_buffer(buf, count, ppos, out, rc);
33 }
34
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki