Re: [PATCH v3 03/11] KVM: x86/mmu: Use KVM honors guest MTRRs helper when CR0.CD toggles

From: Yan Zhao
Date: Wed Jun 28 2023 - 22:08:43 EST


On Wed, Jun 28, 2023 at 02:59:00PM -0700, Sean Christopherson wrote:
> On Fri, Jun 16, 2023, Yan Zhao wrote:
> > Call helper to check if guest MTRRs are honored by KVM MMU before zapping,
>
> Nit, state the effect, not what the code literally does. The important part is
> that the end result is that KVM will zap if and only if guest MTRRs are being
> honored, e.g.
>
> Zap SPTEs when CR0.CD is toggled if and only if KVM's MMU is honoring
> guest MTRRs, which is the only time that KVM incorporates the guest's
> CR0.CD into the final memtype.
>
Thanks! Will update it.