Re: [RFC PATCH 1/8] PCI: Add Intel Audio DSP devices to pci_ids.h

[Amadeusz Sławiński]

On 6/28/2023 4:44 PM, Andy Shevchenko wrote:
> On Wed, Jun 28, 2023 at 10:51:28PM +0200, Amadeusz Sławiński wrote:
> > Those IDs are mostly sprinkled between HDA, Skylake, SOF and avs drivers.
> > Almost every use contains additional comments to identify to which
> > platform those IDs refer to. Add those IDs to pci_ids.h header, so that
> > there is one place which defines those names.
>
> ...
>
> >   #define PCI_DEVICE_ID_INTEL_5400_FBD0	0x4035
> >   #define PCI_DEVICE_ID_INTEL_5400_FBD1	0x4036
> > +#define PCI_DEVICE_ID_INTEL_HDA_JSL_N	0x4dc8
> > +#define PCI_DEVICE_ID_INTEL_HDA_TGL_H	0x43c8
> > +#define PCI_DEVICE_ID_INTEL_HDA_EHL_0	0x4b55
> > +#define PCI_DEVICE_ID_INTEL_HDA_EHL_3	0x4b58
>
> Can it be kept sorted by a value?
>
> Didn't check the full list, though.

My mistake, I've tried to add them in order, but must have missed this 
one, will review whole list again.