Re: [PATCH v2 1/1] Add a new sysctl to disable io_uring system-wide

From: Bart Van Assche
Date: Thu Jun 29 2023 - 13:37:47 EST


On 6/29/23 08:28, Matteo Rizzo wrote:
On Thu, 29 Jun 2023 at 17:16, Bart Van Assche <bvanassche@xxxxxxx> wrote:

On 6/29/23 06:27, Matteo Rizzo wrote:
+static int __read_mostly sysctl_io_uring_disabled;

Shouldn't this be a static key instead of an int in order to minimize the
performance impact on the io_uring_setup() system call? See also
Documentation/staging/static-keys.rst.

Is io_uring_setup in any hot path? io_uring_create is marked as __cold.

I confused io_uring_setup() with io_uring_enter() so please ignore my comment.

Bart.