Re: [PATCH] usb: typec: ucsi: move typec_set_mode(TYPEC_STATE_SAFE) to ucsi_unregister_partner()

From: Heikki Krogerus
Date: Fri Jun 30 2023 - 08:49:29 EST


On Mon, Jun 26, 2023 at 06:52:00PM +0200, Neil Armstrong wrote:
> It's better to set TYPEC_STATE_SAFE mode from ucsi_unregister_partner()
> instead of ucsi_partner_change(), ucsi_unregister_partner() is always
> when the partner disconnects.
>
> Fixes: 25a2bc21c863 ("usb: typec: ucsi: call typec_set_mode on non-altmode partner change")
> Suggested-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

thanks,

--
heikki