Re: [PATCH] kdb: move kdb_send_sig() declaration to a better header file

[Doug Anderson]

Hi,

On Fri, Jun 30, 2023 at 1:12 PM Daniel Thompson
<daniel.thompson@xxxxxxxxxx> wrote:
>
> kdb_send_sig() is defined in the signal code and called from kdb,
> but the declaration is part of the kdb internal code.
> Move the declaration to the shared header to avoid the warning:
>
> kernel/signal.c:4789:6: error: no previous prototype for 'kdb_send_sig' [-Werror=missing-prototypes]
>
> Reported-by: Arnd Bergmann <arnd@xxxxxxxx>

FWIW: these days, I think checkpatch yells at you for a bare
"Reported-by" like above. It ideally wants a "Closes" tag to follow
immediately with a link to the report, or in the very least a "Link"
tag if this doesn't fully address the issue.

> Signed-off-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>