Re: [PATCH 6.4 00/28] 6.4.1-rc1 review

[Guenter Roeck]

On 6/29/23 23:47, Linus Torvalds wrote:
> On Thu, 29 Jun 2023 at 23:33, Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> > Oh well.  We'll get them all. Eventually. Let me go fix up that csky case.
>
> It's commit e55e5df193d2 ("csky: fix up lock_mm_and_find_vma() conversion").
>
> Let's hope all the problems are these kinds of silly - but obvious -
> naming differences between different architectures.
>
> Because as long as they cause build errors, they may be embarrassing,
> but easy to find and notice.
>
> I may not have cared enough about some of these architectures, and it
> shows. sparc32. parisc. csky...

There is one more, unfortunately.

Building xtensa:de212:kc705-nommu:nommu_kc705_defconfig ... failed
------------
Error log:
arch/xtensa/mm/fault.c: In function ‘do_page_fault’:
arch/xtensa/mm/fault.c:133:8: error: implicit declaration of function ‘lock_mm_and_find_vma’

This affects all stable release candidates as well as mainline.
mmu builds are fine, and indeed lock_mm_and_find_vma() is only declared
for CONFIG_MMU. I don't know if this needs a dummy or some other fix
for the nommu case.

Guenter