Re: [Patch v3] net: mana: Batch ringing RX queue doorbell on receiving packets

From: Jakub Kicinski
Date: Fri Jun 30 2023 - 19:38:13 EST


On Fri, 30 Jun 2023 20:42:28 +0000 Long Li wrote:
> > > 5.15 and kernel 6.1. (those kernels are longterm) They need this fix to achieve
> > > the performance target.
> >
> > Why can't they be upgraded to get that performance target, and all the other
> > goodness that those kernels have? We don't normally backport new features,
> > right?
>
> I think this should be considered as a fix, not a new feature.
>
> MANA is designed to be 200GB full duplex at the start. Due to lack of
> hardware testing capability at early stage of the project, we could only test 100GB
> for the Linux driver. When hardware is fully capable of reaching designed spec,
> this bug in the Linux driver shows up.

That part we understand.

If I were you I'd try to convince Greg and Paolo that the change is
small and significant for user experience. And answer Greg's question
why upgrading the kernel past 6.1 is a challenge in your environment.