Re: [PATCH] i2c: stm32f7: Add atomic_xfer method to driver

[Sean Nyekjaer]

> On 23 Jun 2023, at 12.33, Wolfram Sang <wsa@xxxxxxxxxx> wrote:
> 
> On Tue, May 09, 2023 at 03:21:59PM +0200, Sean Nyekjaer wrote:
>> Add an atomic_xfer method to the driver so that it behaves correctly
>> when controlling a PMIC that is responsible for device shutdown.
>> 
>> The atomic_xfer method added is similar to the one from the i2c-mv64xxx
>> driver. When running an atomic_xfer a bool flag in the driver data is
>> set, the interrupt is not unmasked on transfer start, and the IRQ
>> handler is manually invoked while waiting for pending transfers to
>> complete.
>> 
>> Signed-off-by: Sean Nyekjaer <sean@xxxxxxxxxx>
> 
> Pierre-Yves, Alain, any further comments to this patch?
> 
>> Is it okay to keep the DMA transfer in atomic?
> 
> Will DMA actually run in atomic mode?
> 

Hi Wolfram,

Atomic is mainly(only) used for writing a single register in the PMIC for the stpmic. Guess that will not trigger any DMA use.
But let’s wait for other comments…

/Sean