Re: [PATCH v3 1/3] drm: Improve Kconfig symbol prompt and help texts

From: Javier Martinez Canillas
Date: Mon Jul 03 2023 - 05:48:06 EST


Thomas Zimmermann <tzimmermann@xxxxxxx> writes:

> Hi Javier
>
> Am 02.07.23 um 21:15 schrieb Javier Martinez Canillas:

[...]

>> - Kernel-level support for the Direct Rendering Infrastructure (DRI)
>> - introduced in XFree86 4.0. If you say Y here, you need to select
>> - the module that's right for your graphics card from the list below.
>> - These modules provide support for synchronization, security, and
>> - DMA transfers. Please see <http://dri.sourceforge.net/> for more
>> - details. You should also select and configure AGP
>> - (/dev/agpgart) support if it is available for your platform.
>> + Kernel-level support for the Direct Rendering Infrastructure (DRI),
>> + that is composed of the Direct Rendering Manager (DRM) and Kernel
>> + Mode Settings (KMS) subsystems.
>
> It's slightly off, as KMS is part of DRM. I'd just drop any mention of KMS.
>
> But TBH instead of these small fixes, we should first discuss how we

Right, I'll just drop this patch and we can cleanup the text later.

> organize the menu structures. For example, the DRM drivers are all
> listed in the graphics menu. They might as well go into a DRM menu.
>
> The framebuffer will be split into drivers and 'core'. The core options
> (FB_DEVICE, FIRMWARE_EDID, FB_*_ENDIAN) probably deserve a separate menu.
>

Yes, that is what we agreed with Arnd and Geert. To add a new Kconfig in
drivers/video/fbdev/core/Kconfig and drivers/video/fbdev/Kconfig source it.

> And there's the framebuffer console, which has its own menu. We need to
> show it even if only DRM is supported. Plus the other consoles.
>
> I'm not sure what drivers/auxdisplay is, it might fit here as well.
>

That seems to be for simple character-based displays. And agree that could
be in framebuffer console as well. So we should improve the menu structure
before attempting to complicate with more options like adding the FB_CORE.

> It would be nice to rethink the overall menu.
>
> Best regards
> Thomas
>

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat