Re: [PATCH 1/3] dt-bindings: arm: fsl: fix DEBIX binding
From: Krzysztof Kozlowski
Date: Wed Jul 05 2023 - 05:15:45 EST
On 05/07/2023 10:28, Marco Felsch wrote:
> Hi Krzysztof,
>
> On 23-07-05, Krzysztof Kozlowski wrote:
>> On 04/07/2023 20:41, Marco Felsch wrote:
>>> The current imx8mp-debix-model-a.dts uses all three compatibles. Fix the
>>> corresponding bindings by adding an own entry for it.
>>>
>>> Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
>>> ---
>>> Documentation/devicetree/bindings/arm/fsl.yaml | 9 +++++++--
>>> 1 file changed, 7 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>>> index 15d4110840654..d9e763ef932e5 100644
>>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>>> @@ -1019,8 +1019,6 @@ properties:
>>> - dmo,imx8mp-data-modul-edm-sbc # i.MX8MP eDM SBC
>>> - fsl,imx8mp-evk # i.MX8MP EVK Board
>>> - gateworks,imx8mp-gw74xx # i.MX8MP Gateworks Board
>>> - - polyhex,imx8mp-debix # Polyhex Debix boards
>>> - - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board
>>> - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules
>>> - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT
>>> - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules
>>> @@ -1054,6 +1052,13 @@ properties:
>>> - const: phytec,imx8mp-phycore-som # phyCORE-i.MX8MP SoM
>>> - const: fsl,imx8mp
>>>
>>> + - description: Polyhex DEBIX i.MX8MP based SBCs
>>> + items:
>>> + - enum:
>>> + - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board
>>> + - const: polyhex,imx8mp-debix # Polyhex Debix boards
>>
>> Same comments as for patch #2. I think this should be rather deprecated
>> - not a good pattern.
>
> How can we deprecate a binding?
git grep "deprecated:" -- Documentation/devicetree/
Best regards,
Krzysztof