Re: [PATCH v2] kernel/trace: Fix cleanup logic of enable_trace_eprobe

From: Steven Rostedt
Date: Wed Jul 05 2023 - 11:05:51 EST


On Wed, 5 Jul 2023 11:03:02 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Mon, 3 Jul 2023 06:47:12 +0300
> Tzvetomir Stoyanov <tz.stoyanov@xxxxxxxxx> wrote:
>
> > Ok, I'll send v3 with the counter, although I think it is a bit
> > overengineering - that optimization is in code that is unlikely to be
> > executed.
>
> It's not really over-engineering. We have this type of logic all over the
> kernel. When rolling back something, you really only want to rollback what
> you did, and not more. It prevents future bugs and makes things a bit more
> robust.
>
> I'll go pick up v3 now.
>

Masami, I see you delegated this patch to yourself. If you have something
you are working on to send to Linus soon, I'll let you take it.

Reviewed-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>

-- Steve