Re: [Linux-stm32] [PATCH 5/5] dmaengine: stm32-dma: Use devm_platform_get_and_ioremap_resource()

[Amelie Delaunay]

On 7/5/23 10:18, Yangtao Li wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>

Reviewed-by: Amelie Delaunay <amelie.delaunay@xxxxxxxxxxx>
Tested-by: Amelie Delaunay <amelie.delaunay@xxxxxxxxxxx>

> ---
>   drivers/dma/stm32-dma.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/stm32-dma.c b/drivers/dma/stm32-dma.c
> index 37674029cb42..5c36811aa134 100644
> --- a/drivers/dma/stm32-dma.c
> +++ b/drivers/dma/stm32-dma.c
> @@ -1581,8 +1581,7 @@ static int stm32_dma_probe(struct platform_device *pdev)
>   
>   	dd = &dmadev->ddev;
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	dmadev->base = devm_ioremap_resource(&pdev->dev, res);
> +	dmadev->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>   	if (IS_ERR(dmadev->base))
>   		return PTR_ERR(dmadev->base);
>