Re: [PATCH -next 2/3] md/dm-raid: cleanup multiple equivalent goto tags from raid_ctr()

From: Paul Menzel
Date: Thu Jul 06 2023 - 09:02:00 EST


Dear Yu,


Thank you for your patch. Some minor nits, if you are interested.

Am 06.07.23 um 09:16 schrieb Yu Kuai:
From: Yu Kuai <yukuai3@xxxxxxxxxx>

There are four equivalent goto tags in raid_ctr(), clean them up to use
just one, there are no functional change and prepare to fix that

Maybe:

There *is* no functional change, and is a preparation to fix an unprotected `md_stop()`.

md_stop() is not protected.

In the commit message summary/title, I’d spell the verb with a space:

Clean up four equivalent goto tags in raid_ctr()

Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx>
---
drivers/md/dm-raid.c | 27 +++++++++------------------
1 file changed, 9 insertions(+), 18 deletions(-)

[…]


Kind regards,

Paul