Re: [PATCH v2 70/92] qnx6: convert to ctime accessor functions

From: Jan Kara
Date: Thu Jul 06 2023 - 10:01:13 EST


On Wed 05-07-23 15:01:35, Jeff Layton wrote:
> In later patches, we're going to change how the inode's ctime field is
> used. Switch to using accessor functions instead of raw accesses of
> inode->i_ctime.
>
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

Honza

> ---
> fs/qnx6/inode.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/qnx6/inode.c b/fs/qnx6/inode.c
> index 85b2fa3b211c..21f90d519f1a 100644
> --- a/fs/qnx6/inode.c
> +++ b/fs/qnx6/inode.c
> @@ -562,8 +562,7 @@ struct inode *qnx6_iget(struct super_block *sb, unsigned ino)
> inode->i_mtime.tv_nsec = 0;
> inode->i_atime.tv_sec = fs32_to_cpu(sbi, raw_inode->di_atime);
> inode->i_atime.tv_nsec = 0;
> - inode->i_ctime.tv_sec = fs32_to_cpu(sbi, raw_inode->di_ctime);
> - inode->i_ctime.tv_nsec = 0;
> + inode_set_ctime(inode, fs32_to_cpu(sbi, raw_inode->di_ctime), 0);
>
> /* calc blocks based on 512 byte blocksize */
> inode->i_blocks = (inode->i_size + 511) >> 9;
> --
> 2.41.0
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR