Re: [PATCH v2 84/92] linux: convert to ctime accessor functions

From: Jeff Layton
Date: Thu Jul 06 2023 - 11:05:43 EST


On Thu, 2023-07-06 at 16:53 +0200, Jan Kara wrote:
> On Wed 05-07-23 15:01:49, Jeff Layton wrote:
> > In later patches, we're going to change how the inode's ctime field is
> > used. Switch to using accessor functions instead of raw accesses of
> > inode->i_ctime.
> >
> > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
>
> Looks good. Feel free to add:
>
> Reviewed-by: Jan Kara <jack@xxxxxxx>
>
> Honza
>

I'll fix the subject line on this one too, which should be "fs_stack:".
Many thanks for all of the review!

> > ---
> > include/linux/fs_stack.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/fs_stack.h b/include/linux/fs_stack.h
> > index 54210a42c30d..010d39d0dc1c 100644
> > --- a/include/linux/fs_stack.h
> > +++ b/include/linux/fs_stack.h
> > @@ -24,7 +24,7 @@ static inline void fsstack_copy_attr_times(struct inode *dest,
> > {
> > dest->i_atime = src->i_atime;
> > dest->i_mtime = src->i_mtime;
> > - dest->i_ctime = src->i_ctime;
> > + inode_set_ctime_to_ts(dest, inode_get_ctime(src));
> > }
> >
> > #endif /* _LINUX_FS_STACK_H */
> > --
> > 2.41.0
> >

--
Jeff Layton <jlayton@xxxxxxxxxx>