Re: [PATCH 03/11] ARM: dts: qcom: Update devicetree for ADC7 rename for QCOM PMICs

[Krzysztof Kozlowski]

On 08/07/2023 09:28, Jishnu Prakash wrote:
> The name "ADC7" needs to be replaced with the name "ADC5_GEN2"
> everywhere to match the convention used for these ADC peripherals
> on Qualcomm Technologies, Inc. PMICs. Update devicetree files for

We do not rename compatibles to match convention. Please provide proper
rationale.

> the corresponding name change done in bindings and driver.
> 
> Signed-off-by: Jishnu Prakash <quic_jprakash@xxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/pmk8350.dtsi         |  4 +-
>  arch/arm64/boot/dts/qcom/sc7280-idp.dts       |  4 +-
>  arch/arm64/boot/dts/qcom/sc7280-idp.dtsi      |  4 +-
>  arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi    |  8 ++--
>  .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    | 48 +++++++++----------
>  arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi  |  2 +-
>  .../boot/dts/qcom/sm7225-fairphone-fp4.dts    |  4 +-
>  7 files changed, 37 insertions(+), 37 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pmk8350.dtsi b/arch/arm64/boot/dts/qcom/pmk8350.dtsi
> index bc6297e7253e..149d2bb43d2d 100644
> --- a/arch/arm64/boot/dts/qcom/pmk8350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmk8350.dtsi
> @@ -50,7 +50,7 @@ pon_resin: resin {
>  		};
>  
>  		pmk8350_vadc: adc@3100 {
> -			compatible = "qcom,spmi-adc7";
> +			compatible = "qcom,spmi-adc5-gen2";

You break all users without explaining it.

Best regards,
Krzysztof