Re: [PATCH] net: sched: Replace strlcpy with strscpy

[Pavan Chebbi]

On Mon, Jul 10, 2023 at 8:37 AM Azeem Shaikh <azeemshaikh38@xxxxxxxxx> wrote:
>
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
>
> Direct replacement is safe here since return value of -errno
> is used to check for truncation instead of sizeof(dest).
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38@xxxxxxxxx>
> ---

Looks good to me.
Reviewed-by: Pavan Chebbi <pavan.chebbi@xxxxxxxxxxxx>

>  net/sched/act_api.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sched/act_api.c b/net/sched/act_api.c
> index f7887f42d542..9d3f26bf0440 100644
> --- a/net/sched/act_api.c
> +++ b/net/sched/act_api.c
> @@ -1320,7 +1320,7 @@ struct tc_action_ops *tc_action_load_ops(struct nlattr *nla, bool police,
>                         return ERR_PTR(err);
>                 }
>         } else {
> -               if (strlcpy(act_name, "police", IFNAMSIZ) >= IFNAMSIZ) {
> +               if (strscpy(act_name, "police", IFNAMSIZ) < 0) {
>                         NL_SET_ERR_MSG(extack, "TC action name too long");
>                         return ERR_PTR(-EINVAL);
>                 }
> --
> 2.41.0.255.g8b1d071c50-goog
>
>
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature