Re: [PATCH] erofs: avoid unnecessary loops in z_erofs_pcluster_readmore() when read page beyond EOF

From: Gao Xiang
Date: Mon Jul 10 2023 - 00:40:21 EST




On 2023/7/10 12:25, Chunhai Guo wrote:
z_erofs_pcluster_readmore() may take a long time to loop when the page
offset is large enough, which is unnecessary should be prevented.
For example, when the following case is encountered, it will loop 4691368
times, taking about 27 seconds.
- offset = 19217289215
- inode_size = 1442672

Signed-off-by: Chunhai Guo <guochunhai@xxxxxxxx>

It looks good to me,

Fixes: 386292919c25 ("erofs: introduce readmore decompression strategy")
Reviewed-by: Gao Xiang <hsiangkao@xxxxxxxxxxxxxxxxx>

Thanks,
Gao Xiang