Re: [PATCH v2] arm64: dts: imx8ulp-evk: add caam jr

[Krzysztof Kozlowski]

On 10/07/2023 07:27, Pankaj Gupta wrote:
> Hi All,
> 
> Gentle reminder. Please review this patch.
> 
> Thanks.
> Pankaj
> 
>> -----Original Message-----
>> From: Pankaj Gupta <pankaj.gupta@xxxxxxx>
>> Sent: Monday, June 26, 2023 10:17 AM
>> To: robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx;
>> conor+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx;
>> kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; dl-linux-imx <linux-
>> imx@xxxxxxx>; devicetree@xxxxxxxxxxxxxxx; linux-arm-
>> kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>> Cc: Pankaj Gupta <pankaj.gupta@xxxxxxx>; Varun Sethi <V.Sethi@xxxxxxx>
>> Subject: [PATCH v2] arm64: dts: imx8ulp-evk: add caam jr
>>
>> V2: Changed the email subject line.
>> ------------------------------------------------
>>
>>

That's not a place for changelog. It goes after --- .

>> Add crypto node in device tree for:
>> - CAAM job-ring
>>
>> Signed-off-by: Varun Sethi <v.sethi@xxxxxxx>
>> Signed-off-by: Pankaj Gupta <pankaj.gupta@xxxxxxx>
>> ---
>>  arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 32
>> ++++++++++++++++++++++
>>  1 file changed, 32 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
>> b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
>> index 32193a43ff49..ce8de81cac9a 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
>> @@ -207,6 +207,38 @@ pcc3: clock-controller@292d0000 {
>>  				#reset-cells = <1>;
>>  			};
>>
>> +			crypto: crypto@292e0000 {
>> +				compatible = "fsl,sec-v4.0";
>> +				#address-cells = <1>;
>> +				#size-cells = <1>;
>> +				reg = <0x292e0000 0x10000>;

reg is after compatible

>> +				ranges = <0 0x292e0000 0x10000>;

ranges should be third.

>> +


Best regards,
Krzysztof