[PATCH] drm/nouveau/i2c: do not use assignment in if condition

From: sunran001
Date: Mon Jul 10 2023 - 02:38:13 EST


Assignments in if condition are less readable and error-prone. Fixes
also checkpatch warning:

ERROR: do not use assignment in if condition

Signed-off-by: Ran Sun <sunran001@xxxxxxxxxx>
---
drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c
index 96bbdda0f439..a1cf406ff141 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c
@@ -85,7 +85,8 @@ gf119_i2c_bus_new(struct nvkm_i2c_pad *pad, int id, u8 drive,
{
struct gf119_i2c_bus *bus;

- if (!(bus = kzalloc(sizeof(*bus), GFP_KERNEL)))
+ bus = kzalloc(sizeof(*bus), GFP_KERNEL);
+ if (!bus)
return -ENOMEM;
*pbus = &bus->base;