Re: [PATCH v7 1/3] ublk: add opcode offsets for DRV_IN/DRV_OUT

From: Christoph Hellwig
Date: Mon Jul 10 2023 - 02:55:09 EST


On Mon, Jul 10, 2023 at 08:46:04AM +0200, Andreas Hindborg wrote:
> +#define UBLK_IO_OP_WRITE_ZEROES 5
> +/*
> + * Ublk passthrough operation code ranges, and each passthrough operation
> + * provides generic interface between ublk kernel driver and ublk userspace, and
> + * this interface is usually used for handling generic block layer request, such
> + * as command of zoned report zones. Passthrough operation is only needed iff
> + * ublk kernel driver has to be involved for handling this operation.
> + */
> +#define __UBLK_IO_OP_DRV_IN_START 32
> +#define __UBLK_IO_OP_DRV_IN_END 96
> +#define __UBLK_IO_OP_DRV_OUT_START __UBLK_IO_OP_DRV_IN_END
> +#define __UBLK_IO_OP_DRV_OUT_END 160

I guess I was just a little late to catch this before your resend,
sorry. Please look at my comment on the last iteration.