Re: [PATCH HID v1] HID: nvidia-shield: Pack inner/related declarations in HOSTCMD reports

From: Benjamin Tissoires
Date: Mon Jul 10 2023 - 04:33:33 EST


On Tue, 04 Jul 2023 23:04:14 -0700, Rahul Rameshbabu wrote:
> Match alignment information in composite type declarations used by packed
> HOSTCMD report structures. Compiler packing attribute is not recursive for
> inner declarations. Mismatched alignment information can cause undefined
> behavior in code generated for accessing composite type members. struct
> pointers passed to thunderstrike_parse_board_info_payload and
> thunderstrike_parse_haptics_payload are an example of this being
> potentially problematic since alignment information from the packed HOSTCMD
> report is lost.
>
> [...]

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git (for-6.5/upstream-fixes), thanks!

[1/1] HID: nvidia-shield: Pack inner/related declarations in HOSTCMD reports
https://git.kernel.org/hid/hid/c/8bcf314b92ed

Cheers,
--
Benjamin Tissoires <bentiss@xxxxxxxxxx>