Re: [PATCH 5/8] fpga: xilinx-pr-decoupler: Convert to devm_platform_ioremap_resource()

From: Xu Yilun
Date: Mon Jul 10 2023 - 04:45:53 EST


On 2023-07-07 at 06:55:33 +0200, Michal Simek wrote:
>
>
> On 7/5/23 11:46, Yangtao Li wrote:
> > Use devm_platform_ioremap_resource() to simplify code.
> >
> > Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>
> > ---
> > drivers/fpga/xilinx-pr-decoupler.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
> > index b76d85449b8f..208d9560f56d 100644
> > --- a/drivers/fpga/xilinx-pr-decoupler.c
> > +++ b/drivers/fpga/xilinx-pr-decoupler.c
> > @@ -108,7 +108,6 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev)
> > struct xlnx_pr_decoupler_data *priv;
> > struct fpga_bridge *br;
> > int err;
> > - struct resource *res;
> > priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
> > if (!priv)
> > @@ -122,8 +121,7 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev)
> > priv->ipconfig = match->data;
> > }
> > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - priv->io_base = devm_ioremap_resource(&pdev->dev, res);
> > + priv->io_base = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(priv->io_base))
> > return PTR_ERR(priv->io_base);
>
> Acked-by: Michal Simek <michal.simek@xxxxxxx>

Acked-by: Xu Yilun <yilun.xu@xxxxxxxxx>

Applied.

>
> M