Re: [PATCH] drm/nouveau/iccsense:

[Bagas Sanjaya]

On Mon, Jul 10, 2023 at 03:06:47PM +0800, sunran001@xxxxxxxxxx wrote:
> Fixed error: 'do not use assignment in if condition'
> 
> This patch fixes error: 'do not use assignment in if condition'
> in drm/nouveau/iccsense

I guess this is checkpatch fix, right?

> 
> Signed-off-by: Ran Sun <sunran001@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> index 8f0ccd3664eb..2428f3d6e477 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> @@ -322,7 +322,8 @@ int
>  nvkm_iccsense_new_(struct nvkm_device *device, enum nvkm_subdev_type type,
> int inst,
>             struct nvkm_iccsense **iccsense)
>  {
> -    if (!(*iccsense = kzalloc(sizeof(**iccsense), GFP_KERNEL)))
> +    *iccsense = kzalloc(sizeof(**iccsense), GFP_KERNEL);
> +    if (!*iccsense)
>          return -ENOMEM;
>      INIT_LIST_HEAD(&(*iccsense)->sensors);
>      INIT_LIST_HEAD(&(*iccsense)->rails);

Your patch is corrupted (tabs converted to spaces) because you're using
Roundcube. Please use git-send-mail(1) instead.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Attachment: signature.asc
Description: PGP signature