Re: [PATCH v2 3/3] dyndbg: add source filename to prefix

[Luis Chamberlain]

On Sun, Jul 09, 2023 at 11:18:00PM +0200, Thomas Weißschuh wrote:
> Printing the line number without the file is of limited usefulness.
> 
> Knowing the filename also makes it also easier to relate the logged
> information to the controlfile.
> 
> Example:
> 
>     # modprobe test_dynamic_debug
>     # echo 'file test_dynamic_debug.c =pfsl' > /proc/dynamic_debug/control
>     # echo 1 > /sys/module/test_dynamic_debug/parameters/do_prints
>     # dmesg | tail -2
>     [   71.802212] do_cats:lib/test_dynamic_debug.c:103: test_dd: doing categories
>     [   71.802227] do_levels:lib/test_dynamic_debug.c:123: test_dd: doing levels
> 
> Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> Acked-by: Jim Cromie <jim.cromie@xxxxxxxxx>
> Acked-by: Jason Baron <jbaron@xxxxxxxxxx>

Reviewed-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>

  Luis