Re: [PATCH v1 1/1] gpio: mmio: handle "ngpios" properly in bgpio_init()

[Andy Shevchenko]

On Tue, Jul 11, 2023 at 12:22 AM Asmaa Mnebhi <asmaa@xxxxxxxxxx> wrote:
>
> bgpio_init() uses "sz" argument to populate ngpio, which is not
> accurate. Instead, read the "ngpios" property from the DT and if it
> doesn't exist, use the "sz" argument. With this change, drivers no
> longer need to overwrite the ngpio variable after calling bgpio_init().
>
> If the "ngpios" property is specified, bgpio_bits is calculated
> as the round up value of ngpio. At the moment, the only requirement
> specified is that the round up value must be a multiple of 8 but
> it should also be a power of 2 because we provide accessors based
> on the bank size in bgpio_setup_accessors().

The below should be in the changelog area.
Moreover, it doesn't explain why you dropped my tags.

> The following 2 patches were approved in the past but didn't make it
> into the tree. I combined them into one patch since the second one
> fixes a bug in the first one:
> [PATCH v4] gpio: mmio: handle "ngpios" properly in bgpio_init()
> [PATCH v1] gpio: mmio: fix calculation of bgpio_bits

Please, try again.

-- 
With Best Regards,
Andy Shevchenko