Re: [PATCH v9 0/7] Re-enable IDXD kernel workqueue under DMA API

[Baolu Lu]

On 2023/7/11 1:18, Jacob Pan wrote:
> Hi Baolu, Joerg, and all,

Hi Jacob,

> Just wondering if there are more comments?
>
> Thanks,
>
> Jacob
>
> On Wed, 21 Jun 2023 13:59:40 -0700, Jacob Pan
> <jacob.jun.pan@xxxxxxxxxxxxxxx>  wrote:
>
> > Hi Joerg and all,
> >
> > IDXD kernel work queues were disabled due to the flawed use of kernel VA
> > and SVA API.
> > Link:
> > https://lore.kernel.org/linux-iommu/20210511194726.GP1002214@xxxxxxxxxx/
> >
> > The solution is to enable it under DMA API where IDXD shared workqueue
> > users can use ENQCMDS to submit work on buffers mapped by DMA API.
> >
> > This patchset adds support for attaching PASID to the device's default
> > domain and the ability to allocate global PASIDs from IOMMU APIs. IDXD
> > driver can then re-enable the kernel work queues and use them under DMA
> > API.
> >
> > This depends on the IOASID removal series. (merged)
> > https://lore.kernel.org/all/ZCaUBJvUMsJyD7EW@xxxxxxxxxx/
> >
> >
> > Thanks,
> >
> > Jacob
> >
> > ---
> > Changelog:
> > v9:
> > 	- Fix an IDXD driver issue where user interrupt enable bit got
> > cleared during device enable/disable cycle. Reported and tested by
> > 	  Tony Zhu<tony.zhu@xxxxxxxxx>
> > 	- Rebased to v6.4-rc7

Thanks for fixing this.

It seems that you missed some review comments for v8. I can help to test
and merge when all comments are addressed.

Best regards,
baolu