[PATCH] drm/nouveau/flcn/qmgr: Move assignment outside if condition
From: sunran001
Date: Mon Jul 10 2023 - 23:43:55 EST
Fixes the following checkpatch errors:
ERROR: do not use assignment in if condition
Signed-off-by: Ran Sun <sunran001@xxxxxxxxxx>
---
drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.c
b/drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.c
index a453de341a75..48abdb124326 100644
--- a/drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.c
+++ b/drivers/gpu/drm/nouveau/nvkm/falcon/qmgr.c
@@ -73,7 +73,8 @@ nvkm_falcon_qmgr_new(struct nvkm_falcon *falcon,
struct nvkm_falcon_qmgr *qmgr;
int i;
- if (!(qmgr = *pqmgr = kzalloc(sizeof(*qmgr), GFP_KERNEL)))
+ qmgr = *pqmgr = kzalloc(sizeof(*qmgr), GFP_KERNEL);
+ if (!qmgr)
return -ENOMEM;
qmgr->falcon = falcon;