Re: [PATCH v2 1/2] dt-bindings: regulator: Add PMX75 compatible

[Krzysztof Kozlowski]

On 11/07/2023 08:22, Rohit Agarwal wrote:
> 
> On 7/11/2023 11:35 AM, Krzysztof Kozlowski wrote:
>> On 11/07/2023 07:46, Rohit Agarwal wrote:
>>> Add PMX75 compatibles for PMIC found in SDX75 platform.
>>> While at it, update the entry for SDX65 as well.
>> Everything is an update...
>>
>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@xxxxxxxxxxx>
>>> ---
>>>   .../bindings/regulator/qcom,rpmh-regulator.yaml    | 22 +++++++++++++++++++++-
>>>   1 file changed, 21 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
>>> index b949850..72b533c 100644
>>> --- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
>>> +++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
>>> @@ -53,6 +53,7 @@ description: |
>>>         For PMR735A, smps1 - smps3, ldo1 - ldo7
>>>         For PMX55, smps1 - smps7, ldo1 - ldo16
>>>         For PMX65, smps1 - smps8, ldo1 - ldo21
>>> +      For PMX75, smps1 - smps10, ldo1 - ldo21
>>>   
>>>   properties:
>>>     compatible:
>>> @@ -84,6 +85,7 @@ properties:
>>>         - qcom,pmr735a-rpmh-regulators
>>>         - qcom,pmx55-rpmh-regulators
>>>         - qcom,pmx65-rpmh-regulators
>>> +      - qcom,pmx75-rpmh-regulators
>>>   
>>>     qcom,pmic-id:
>>>       description: |
>>> @@ -424,10 +426,28 @@ allOf:
>>>           vdd-l11-l13-supply: true
>>>         patternProperties:
>>>           "^vdd-l[1347]-supply$": true
>>> -        "^vdd-l1[0245789]-supply$": true
>>> +        "^vdd-l1[024579]-supply$": true
>> Why? Does not look related at all.
> This update is because sdx65 does not have vdd-l18-supply separately and 
> its
> already part of vdd-l2-l18-supply property mentioned in the properties 
> field.

Which was not explained in commit msg and is anyway not related. It's a
separate commit.

Best regards,
Krzysztof