Re: [PATCH v2 2/2] libbpf: fix some typo of hashmap init

From: John Sanpe
Date: Tue Jul 11 2023 - 03:09:49 EST


On 7/11/23 05:12, Andrii Nakryiko wrote:

On Mon, Jul 10, 2023 at 10:25 AM Stanislav Fomichev<sdf@xxxxxxxxxx> wrote:
On 07/10, John Sanpe wrote:
Remove the whole HASHMAP_INIT. It's not used anywhere in libbpf.

Signed-off-by: John Sanpe<sanpeqf@xxxxxxxxx>
Acked-by: Stanislav Fomichev<sdf@xxxxxxxxxx>

Doesn't look like it was ever used.
Ack for the change, but the subject doesn't correspond to the change
itself. You are not fixing typo, you are removing static
initialization helper.

Thanks for your suggestion, I have merged the two commits and used a more reasonable subject in v3:

https://lore.kernel.org/all/20230711070712.2064144-1-sanpeqf@xxxxxxxxx