Re: [PATCH 07/13] ALSA: intel-dsp-config: Convert to PCI device IDs defines

[Andy Shevchenko]

On Tue, Jul 11, 2023 at 04:09:42PM +0200, Amadeusz Sławiński wrote:
> On 7/11/2023 4:00 PM, Andy Shevchenko wrote:
> > On Tue, Jul 11, 2023 at 02:57:20PM +0200, Amadeusz Sławiński wrote:

...

> > > -		.device = 0x119a,
> > > +		.device = PCI_DEVICE_ID_INTEL_ADSP_TNG,
> > 
> > Yeah, somebody familiar with Intel history of SST/HDA/wtf should really
> > tell why HDA code is using this ID. Does it mean that SST implies HDA
> > always? Only for this (or this family of) platform?
> > 
> > It might affect the ID naming, but otherwise it's orthogonal to the series.
> > 
> 
> There were few early devices where DSP was separate unit:
> Haswell, Broadwell - where we use ACPI to load (SND_SOC_INTEL_CATPT) audio
> driver, Tangier/Merrifield - where ACPI or PCI is used to load
> (SND_SST_ATOM_HIFI2_PLATFORM_PCI) audio driver.
> All further generations are HDA devices with integrated DSP. This causes all
> the weirdness ;)

Maybe we should stick with SST in the name? At least that's how Tangier TRM
titles it.

-- 
With Best Regards,
Andy Shevchenko