Re: [PATCH] init: Don't proxy console= to earlycon

[Raul Rangel]

On Sat, Jul 8, 2023 at 6:48 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Fri,  7 Jul 2023 19:17:25 -0600 Raul E Rangel <rrangel@xxxxxxxxxxxx> wrote:
>
> > Right now we are proxying the `console=XXX` command line args to the
> > param_setup_earlycon. This is done because the following are
> > equivalent:
> >
> >     console=uart[8250],mmio,<addr>[,options]
> >     earlycon=uart[8250],mmio,<addr>[,options]
> >
> > In addition, when `earlycon=` or just `earlycon` is specified on the
> > command line, we look at the SPCR table or the DT to extract the device
> > options.
> >
> > When `console=` is specified on the command line, it's intention is to
> > disable the console. Right now since we are proxying the `console=`
> > flag to the earlycon handler, we enable the earlycon_acpi_spcr_enable
> > variable when an SPCR table is present. This means that we
> > inadvertently enable the earlycon.
> >
> > This change makes it so we only proxy the console= command if it's
> > value is not empty. This way we can correctly handle both cases.
> >
>
> I hope someone understands this ;)

Is there a more specific list I should send this patch too?

>
> Please "grep -r earlycon Documentation" and check for suitable places
> to update our documentation.
>

The documentation is correct, this just makes the code match the
documentation :)