Re: [PATCH 1/8] nvmem: sunxi_sid: Convert to devm_platform_ioremap_resource()

[Jernej Škrabec]

Dne četrtek, 06. julij 2023 ob 06:04:57 CEST je Yangtao Li napisal(a):
> Use devm_platform_ioremap_resource() to simplify code.
> 
> Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>

Acked-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>

Best regards,
Jernej

> ---
>  drivers/nvmem/sunxi_sid.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/nvmem/sunxi_sid.c b/drivers/nvmem/sunxi_sid.c
> index a970f1741cc6..6bfe02ab169a 100644
> --- a/drivers/nvmem/sunxi_sid.c
> +++ b/drivers/nvmem/sunxi_sid.c
> @@ -125,7 +125,6 @@ static int sun8i_sid_read_by_reg(void *context, unsigned
> int offset, static int sunxi_sid_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
> -	struct resource *res;
>  	struct nvmem_config *nvmem_cfg;
>  	struct nvmem_device *nvmem;
>  	struct sunxi_sid *sid;
> @@ -142,8 +141,7 @@ static int sunxi_sid_probe(struct platform_device *pdev)
> return -EINVAL;
>  	sid->value_offset = cfg->value_offset;
> 
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	sid->base = devm_ioremap_resource(dev, res);
> +	sid->base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(sid->base))
>  		return PTR_ERR(sid->base);