Re: [PATCH v3] pwm: atmel: Enable clk when pwm already enabled in bootloader

[Uwe Kleine-König]

Hello,

On Wed, Jul 12, 2023 at 04:09:05AM +0800, Guiting Shen wrote:
> +static int atmel_pwm_enable_clk_if_on(struct atmel_pwm_chip *atmel_pwm)
> +{
> +	unsigned int i;
> +	int err;
> +	u32 sr;
> +
> +	sr = atmel_pwm_readl(atmel_pwm, PWM_SR);
> +	if (!sr)
> +		return 0;
> +
> +	for (i = 0; i < atmel_pwm->chip.npwm; i++) {
> +		if (!(sr & (1 << i)))
> +			continue;
> +
> +		err = clk_enable(atmel_pwm->clk);
> +		if (err) {
> +			dev_err(atmel_pwm->chip.dev,
> +				"failed to enable clock: %pe\n", ERR_PTR(err));

Here you leak possibly a few enables. While it's not likely that the
(say) third enable goes wrong, it's also not that hard to handle?!

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature