Re: [PATCH v3 7/8] dt-bindings: arm: stm32: add extra SiP compatible for oct,stm32mp157c-osd32-red

[Ahmad Fatoum]

On 12.07.23 11:11, Sean Nyekjaer wrote:
>> On 12 Jul 2023, at 10.38, Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> wrote:
>> On 12.07.23 08:29, Sean Nyekjaer wrote:
>>> Add binding support for the Octavo OSD32MP1-RED development board.
>>>
>>> General features:
>>> - STM32MP157C
>>> - 512MB DDR3
>>> - CAN-FD
>>> - HDMI
>>> - USB-C OTG
>>> - UART
>>>
>>> Signed-off-by: Sean Nyekjaer <sean@xxxxxxxxxx>
>>> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>>
>> Just a heads up: The LXA TAC, another OSD32MP1 board has been merged into
>> stm32-next yesterday, so applying your series onto that tree may result
>> in conflicts. You may want to rebase for v4.
>>
>> Cheers,
>> Ahmad
> 
> Thanks, will do :)
> 
> Can I get you to look at 4/8, 5/8 and 6/8 in this series? Will they break anything for LXA TAC?

Leonard, does the LXA TAC have an implicit dependency on any of the rails that Sean is
now turning off by default?

Cheers,
Ahmad

> 
> /Sean
> 
>>
>>
>>> ---
>>> Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>>> index 13e34241145b..55e45db1af26 100644
>>> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>>> @@ -143,7 +143,8 @@ properties:
>>>       - description: Octavo OSD32MP15x System-in-Package based boards
>>>         items:
>>>           - enum:
>>> -              - lxa,stm32mp157c-mc1 # Linux Automation MC-1
>>> +              - lxa,stm32mp157c-mc1       # Linux Automation MC-1
>>> +              - oct,stm32mp157c-osd32-red # Octavo OSD32MP1 RED board
>>>           - const: oct,stm32mp15xx-osd32
>>>           - enum:
>>>               - st,stm32mp157
>>
>> -- 
>> Pengutronix e.K.                           |                             |
>> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
>> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
>> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |