Re: [PATCH] iio: imu: lsm6dsx: Fix mount matrix retrieval

[Lorenzo Bianconi]

> The function lsm6dsx_get_acpi_mount_matrix should return true when ACPI
> support is not enabled to allow executing iio_read_mount_matrix in the
> probe function.
> 
> Fixes: dc3d25f22b88 ("iio: imu: lsm6dsx: Add ACPI mount matrix retrieval")
> 
> Signed-off-by: Alejandro Tafalla <atafalla@xxxxxxxxx>
> ---
>  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/
> st_lsm6dsx/st_lsm6dsx_core.c
> index 6a18b363cf73..62bc3ee783fb 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> @@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(struct device 
> *dev,
>  static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,
>  					  struct 
> iio_mount_matrix *orientation)
>  {
> -	return false;
> +	return true;

I would say it should return something like -EOPNOTSUPP.

Regards,
Lorenzo

>  }
>  
>  #endif
> -- 
> 2.41.0
> 
> 
> 
>

Attachment: signature.asc
Description: PGP signature