Re: 回复: [PATCH v1] iommu: fix parameter check in tegra_smmu_debugfs_init()

From: Thierry Reding
Date: Wed Jul 12 2023 - 11:06:53 EST


On Wed, Jul 12, 2023 at 12:37:02PM +0000, 杜敏杰 wrote:
> Hi Thierry!
>
> >I think we can just drop the error check altogether since
> >debugfs_create_file() will simply return early if smmu->debugfs is an error pointer.
>
> So do you mean maybe delete the smmu->debugfs check is better?
> Maybe I can resubmit a new patch.

Yes, I think that would be preferable.

Thierry

Attachment: signature.asc
Description: PGP signature