Re: [PATCH v1] drivers: wireless: ath5k: fix parameter check in ath5k_debug_init_device

[Luis Chamberlain]

On Wed, Jul 12, 2023 at 08:42:59PM +0800, Minjie Du wrote:
> Make IS_ERR() judge the debugfs_create_dir() function return
> in ath5k_debug_init_device().
> 
> Signed-off-by: Minjie Du <duminjie@xxxxxxxx>
> ---
>  drivers/net/wireless/ath/ath5k/debug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c
> index 4b41160e5..08058b3f7 100644
> --- a/drivers/net/wireless/ath/ath5k/debug.c
> +++ b/drivers/net/wireless/ath/ath5k/debug.c
> @@ -982,7 +982,7 @@ ath5k_debug_init_device(struct ath5k_hw *ah)
>  	ah->debug.level = ath5k_debug;
>  
>  	phydir = debugfs_create_dir("ath5k", ah->hw->wiphy->debugfsdir);
> -	if (!phydir)
> +	if (IS_ERR(phydir))

Please use IS_ERR_OR_NULL() instead.

With that change added:

Acked-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>

  Luis